rusackas commented on a change in pull request #9525: Migrating shared NVD3
controls to new module
URL:
https://github.com/apache/incubator-superset/pull/9525#discussion_r409990512
##########
File path: superset-frontend/src/explore/controlPanels/Compare.js
##########
@@ -19,6 +19,18 @@
import { t } from '@superset-ui/translation';
import { NVD3TimeSeries, annotations } from './sections';
import { D3_TIME_FORMAT_OPTIONS } from '../controls';
+import {
+ xAxisLabel,
+ yAxisLabel,
+ bottomMargin,
+ xTicksLayout,
+ xAxisFormat,
+ yLogScale,
+ yAxisBounds,
+ xAxisShowMinmax,
+ yAxisShowMinmax,
+ leftMargin,
+} from './Shared_NVD3';
Review comment:
Hmm... I was just going for namespacing, even if temporary. RIght now there
are:
`Shared_NVD3.js`
`Shared_DeckGL.jsx`
`Shared_BigNumber.js`
I imagine when we pull all this stuff into the individual packages, we can
just call them all `SharedControls.js(x)`
If you'd like to get rid of the underscores in the interim (no strong
feelings, here), I might rather just fix all three in a fast-follow PR after
this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
