suddjian commented on a change in pull request #9530: [charts] adds new filters
ui
URL:
https://github.com/apache/incubator-superset/pull/9530#discussion_r410364600
##########
File path: superset-frontend/src/views/chartList/ChartList.tsx
##########
@@ -311,11 +320,24 @@ class ChartList extends React.PureComponent<Props,
State> {
},
loading: true,
});
- const filterExps = filters.map(({ id: col, operator: opr, value }) => ({
- col,
- opr,
- value,
- }));
+ const filterExps = filters
+ .map(({ id: col, operator: opr, value }) => ({
+ col,
+ opr,
+ value,
+ }))
+ .reduce((acc, fltr) => {
+ if (fltr.col === 'datasource' && typeof fltr.value === 'object') {
Review comment:
checking `fltr. value === 'object'` will be true if the value is null, is
that intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
