john-bodley opened a new pull request #9582: [fix] Fixing issue with Jinja filter_value URL: https://github.com/apache/incubator-superset/pull/9582 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR fixes an issue where the Jinja `filter_value` was only adhering to legacy filter constructs (which are still used by the filter box) and thus a query could differ whether executed from a dashboard or from the explorer where the filters are inherited (though in the form of adhoc-filters). The fix is merely to convert the legacy filters to ad-hoc and and merge the extra filters inline with other portions of the code. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Added unit tests and tested manually. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @villebro
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
