john-bodley commented on a change in pull request #9586: [mypy] Enforcing
typing for a number of modules
URL:
https://github.com/apache/incubator-superset/pull/9586#discussion_r410971657
##########
File path: superset/tasks/schedules.py
##########
@@ -368,15 +391,17 @@ def schedule_email_report(
schedule.id = schedule_id
schedule.recipients = recipients
- if report_type == ScheduleType.dashboard.value:
+ if report_type == ScheduleType.dashboard:
Review comment:
This used to parse around the value (str) of the enum as opposed to the enum
instance which seems somewhat atypical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
