john-bodley commented on issue #9572:
URL:
https://github.com/apache/incubator-superset/pull/9572#issuecomment-616235403
@villebro I agree with your point (and noted) that the presence of a URL
parameter does not mean it will be used by the query but per the documentation,
> As you create a visualization form this SQL Lab query, you can pass
parameters in the explore view as well as from the dashboard, and it should
carry through to your queries.
>
> Default values for URL parameters can be defined in chart metadata by
adding the key-value pair `url_params: {'foo': 'bar'}`
I perceive one would expect that if one were using them as defined they
wouldn't expect the cached payload to be incorrect, i.e., it feels like a bug
if they didn't know they needed to wrap the call with `cache_key_wrapper`.
Maybe there's a common ground we could agree on (however I wasn't able to
get it working but maybe you could shed some light on maybe how to do it). Is
there a way of possibly calling `cache_key_wrapper` from within `url_param` to
register `url_params` as extra cache keys? That would ensure these are only
added to the cache if they're used by the query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
