ktmud opened a new pull request #9593: URL: https://github.com/apache/incubator-superset/pull/9593
### CATEGORY - [x] Bug Fix ### SUMMARY "Emit filter events" on table and deck.gl chart has been broken since the introduction of scoped filters. This PR tries to re-enable it by: 1. Re-enable "emit filter events" in Table chart 2. Treat charts with `table_filter == TRUE` as the same as FilterBox in many places. Must wait for the accompanying `superet-ui` PR: https://github.com/apache-superset/superset-ui/pull/344 Fixes #8273 #8683 . ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Clicking on non-metric table cells should trigger a filter update:  `lightcyan` is the selected filter. `lightorange` is the hover state. ### TEST PLAN 1. Go to any dashboard with either a FilterBox or table chart with "Emit Filter Events" enabled. 2. Make sure filters and filter event works, make sure you can still edit the dashboard and filter scope. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @graceguo-supercat @kristw @etr2460 @williaster ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
