villebro commented on issue #9532: URL: https://github.com/apache/incubator-superset/issues/9532#issuecomment-619996182
@axelet Have you tested making these changes locally as a POC? While in principle this makes sense, it would be interesting to see if any problems arise with this change. Also, this does require all tables to conform to a specific column naming convention, so there would need to be logic in place to handle cases where a filter's columns are not present in the table. Also, this could potentially be circumvented by introducing aliases in a SQL query, and injecting filters into the subquery (`expr_qry`) might be problematic, so I'm not sure if these filters can be enforced in SQL Lab as easily as in regular tables. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
