etr2460 opened a new pull request #9677: URL: https://github.com/apache/incubator-superset/pull/9677
### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Beginning implementation of https://github.com/apache/incubator-superset/issues/9194 This PR adds scaffolding for the client side part of custom error messages. No existing behavior should be changed yet. Scaffolding consists of: - introduce an `ErrorMessageComponentRegistry` for registering all error messages by error type - allow individual deployments to override these error messages with `setupErrorMessagesExtra` - display an error message from the registry if one exists for the given type, otherwise show the generic ErrorMessageWithStackTrace Note that this registry is included in the main Superset repo. This is because we only support translations in this repo currently, and it's important to allow all the error messages registered here to have translations. Todo in future PRs: - Add the new error object to client and backend responses - Introduce custom error message components ### TEST PLAN View a dashboard, ensure network errors and hardcoded raised errors still render properly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @graceguo-supercat @ktmud @kristw @rusackas ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
