dpgaspar opened a new pull request #9702: URL: https://github.com/apache/incubator-superset/pull/9702
### CATEGORY - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [X] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Increases BigQuery test coverage to 100%. Took the chance and added more human readable descriptions for this db engines tests Result coverage: ``` superset/db_engine_specs/athena.py 20 3 85% superset/db_engine_specs/base.py 344 40 88% superset/db_engine_specs/bigquery.py 82 0 100% superset/db_engine_specs/clickhouse.py 16 1 94% superset/db_engine_specs/cockroachdb.py 3 0 100% superset/db_engine_specs/db2.py 10 1 90% superset/db_engine_specs/dremio.py 7 1 86% superset/db_engine_specs/drill.py 26 5 81% superset/db_engine_specs/druid.py 34 16 53% superset/db_engine_specs/elasticsearch.py 16 1 94% superset/db_engine_specs/exasol.py 10 2 80% superset/db_engine_specs/gsheets.py 5 0 100% superset/db_engine_specs/hana.py 18 6 67% superset/db_engine_specs/hive.py 232 125 46% superset/db_engine_specs/impala.py 22 4 82% superset/db_engine_specs/kylin.py 14 1 93% superset/db_engine_specs/mssql.py 43 0 100% superset/db_engine_specs/mysql.py 46 21 54% superset/db_engine_specs/oracle.py 25 3 88% superset/db_engine_specs/pinot.py 41 17 59% superset/db_engine_specs/postgres.py 37 0 100% superset/db_engine_specs/presto.py 435 123 72% superset/db_engine_specs/redshift.py 7 1 86% superset/db_engine_specs/snowflake.py 46 10 78% superset/db_engine_specs/sqlite.py 30 8 73% superset/db_engine_specs/teradata.py 9 1 89% superset/db_engine_specs/vertica.py 3 0 100% ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @willbarrett ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
