graceguo-supercat opened a new pull request #9706: URL: https://github.com/apache/incubator-superset/pull/9706
### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR will hide `Edit Datasource` option when no onDatasourceSave props is passed in. <img width="395" alt="Screen Shot 2020-04-30 at 11 21 01 AM" src="https://user-images.githubusercontent.com/27990562/80745542-4e077480-8ad5-11ea-8bf4-e6b2682d988e.png";> ### TEST PLAN CI and manual test. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @etr2460 @mistercrunch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/80745542-4e077480-8ad5-11ea-8bf4-e6b2682d988e.png"](https://user-images.githubusercontent.com/27990562/80745542-4e077480-8ad5-11ea-8bf4-e6b2682d988e.png"){kind=link}