graceguo-supercat commented on a change in pull request #9733:
URL:
https://github.com/apache/incubator-superset/pull/9733#discussion_r419808072
##########
File path: superset-frontend/src/logger/LogUtils.js
##########
@@ -19,6 +19,7 @@
// Log event names ------------------------------------------------------------
export const LOG_ACTIONS_LOAD_CHART = 'load_chart';
export const LOG_ACTIONS_RENDER_CHART = 'render_chart';
+export const LOG_ACTIONS_HIDDEN_BROWSER_TAB = 'hidden_browser_tab';
Review comment:
This is a `timing_event`, like `load_chart` and `render_chart`.
To me `start_offset` is also valuable, I can see when user start to switch
browser tab.
Even there is only one valuable attribute, `duration`, this
`hidden_browser_tab ` event still need to send other attribute like
`event_type` and `trigger_event` so that this event will be grouped with
correct dashboard load event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
