bkyryliuk opened a new pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734
Implement function controlled csv upload schema Refactor + fix tests ### CATEGORY Choose one - [x] Enhancement (new features, refinement) - [x] Refactor - [x] Add tests ### SUMMARY This PR implements a standard schema enforcements for the base and hive csv upload. In addition to that it introduces UPLOADED_CSV_SCHEMA_FUNC config variable that can programmatically set a schema for the user during the file upload. In addition to that there are 2 refactorings: 1. simplified `create_table_from_csv` and pushed more logics & validation in to the `form_post` to bring more clarity to the function and not pass a generic form around 2. refactored the tests to make them more reusable across the functions / test cases ### TEST PLAN [x] Unit tests -- in progress [ ] Local testing [ ] Dropbox staging ### REVIEWERS ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
