oashton opened a new pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210


   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Add a new option in the chart contextual menu:
   * The label change between Maximize and Minimize depending of the chart state
   * The maximize chart take all the available space in the browser
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
![image](https://user-images.githubusercontent.com/6887197/75381400-ad16f600-58a6-11ea-817c-361306afbb0d.png)
   
![image](https://user-images.githubusercontent.com/6887197/75381458-c5871080-58a6-11ea-82b8-f63bdd4531e6.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Click in the three dots menu in any chart, click the Maximize option.
   Click again in the three dots menu in any chart, click the Minimize option.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #9209
   - [X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to