etr2460 commented on a change in pull request #9745:
URL:
https://github.com/apache/incubator-superset/pull/9745#discussion_r420493863
##########
File path: superset-frontend/src/dashboard/util/isDashboardEmpty.js
##########
@@ -0,0 +1,27 @@
+/**
Review comment:
Could you make this TypeScript since it's a new file?
##########
File path: superset-frontend/src/dashboard/components/Dashboard.jsx
##########
@@ -90,11 +92,18 @@ class Dashboard extends React.PureComponent {
}
componentDidMount() {
- const eventData = {};
+ const { dashboardState } = this.props;
+ const eventData = {
+ is_editMode: dashboardState.editMode,
+ mount_duration: Logger.getTimestamp(),
+ };
const directLinkComponentId = getLocationHash();
if (directLinkComponentId) {
eventData.target_id = directLinkComponentId;
}
+ if (isDashboardEmpty(this.props.layout)) {
+ eventData.is_empty = true;
+ }
Review comment:
why not do `eventData.is_empty: isDashboardEmpty(this.props.layout)`?
Then we could also do this up on line 98 instead too
##########
File path:
superset-frontend/spec/javascripts/dashboard/util/isDashboardEmpty_spec.js
##########
@@ -0,0 +1,41 @@
+/**
Review comment:
could you make this TypeScript since it's a new file?
##########
File path: superset-frontend/src/dashboard/components/Dashboard.jsx
##########
@@ -90,11 +92,18 @@ class Dashboard extends React.PureComponent {
}
componentDidMount() {
- const eventData = {};
+ const { dashboardState } = this.props;
+ const eventData = {
+ is_editMode: dashboardState.editMode,
Review comment:
let's either do snake_case or camelCase, not a mix of both
##########
File path:
superset-frontend/spec/javascripts/dashboard/util/isDashboardEmpty_spec.js
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import isDashboardEmpty from '../../../../src/dashboard/util/isDashboardEmpty';
+import getEmptyLayout from '../../../../src/dashboard/util/getEmptyLayout';
+
+describe('isDashboardEmpty', () => {
+ const emptyLayout = getEmptyLayout();
+ const testLayout = {
+ ...emptyLayout,
+ 'MARKDOWN-IhTGLhyiTd': {
+ children: [],
+ id: 'MARKDOWN-IhTGLhyiTd',
+ meta: { code: 'test me', height: 50, width: 4 },
+ parents: ['ROOT_ID', 'GRID_ID', 'ROW-uPjcKNYJQy'],
+ type: 'MARKDOWN',
+ },
+ };
+
+ it('should return true for empty dashboard', () => {
+ expect(isDashboardEmpty(emptyLayout)).toBe(true);
+ });
+ it('should return false for empty dashboard', () => {
Review comment:
nit: `should return false for a non-empty dashboard`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
