kristw commented on a change in pull request #9761:
URL:
https://github.com/apache/incubator-superset/pull/9761#discussion_r421653438
##########
File path: superset-frontend/.prettierrc
##########
@@ -1,4 +1,5 @@
{
"singleQuote": true,
- "trailingComma": "all"
+ "trailingComma": "all",
+ "arrowParens": "avoid"
Review comment:
There seems to be another change to space between `function` and
parentheses.
`function() {}` vs `function () {}`
I do not have strong preference in terms of styling but perhaps we can use
the original to reduce amount of changes.
This is the settings from `@superset-ui`
```ts
{
"arrowParens": "avoid",
"bracketSpacing": true,
"jsxBracketSameLine": false,
"printWidth": 100,
"proseWrap": "always",
"requirePragma": false,
"semi": true,
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "all",
"useTabs": false
};
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
