etr2460 commented on a change in pull request #9816:
URL: 
https://github.com/apache/incubator-superset/pull/9816#discussion_r426087506



##########
File path: superset/views/base.py
##########
@@ -141,6 +141,9 @@ def api(f):
     def wraps(self, *args, **kwargs):
         try:
             return f(self, *args, **kwargs)
+        except SupersetSecurityException as ex:

Review comment:
       Shouldn't this be managed by also wrapping the function in 
`handle_api_exception`  as opposed to adding it here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to