[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Sun, 17 May 2020 18:56:24 -0700 


graceguo-supercat opened a new pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829


   ### SUMMARY
   This PR is to fix 2 issues in **single value** filter_box.
   
   ### BEFORE
   
   1. Clear filter_box won't clear filter's default value
   
![gGtwLBI2qw](https://user-images.githubusercontent.com/27990562/82166530-9365c900-986d-11ea-89a6-c60e68c8ab32.gif)
   
   
   1. Set default value for a single value filter_box, the column's data type 
is FLOAT:
   <img width="570" alt="Screen Shot 2020-05-17 at 6 48 57 PM" 
src="https://user-images.githubusercontent.com/27990562/82167010-34a14f00-986f-11ea-9a14-1516e9939aea.png";>
   In dashboard, this string value doesn't match with filter's data type, so 
that it looks the same option show twice:
   <img width="760" alt="Screen Shot 2020-05-17 at 6 50 46 PM" 
src="https://user-images.githubusercontent.com/27990562/82167070-6d412880-986f-11ea-8b5f-21e83cb0cf8b.png";>
   
   Proposed solution:
   
   1. When user clear filter_box, the option value should be null. While when 
filter_box value is undefined, should use defaultValue.
   2. When user update defaultValue for filter_box, add type cast for numeric 
and boolean type column.
    
   
   ### TEST PLAN
   CI and manual test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to