john-bodley opened a new pull request #9846: URL: https://github.com/apache/incubator-superset/pull/9846
### SUMMARY This PR disables `sphinx-autodoc-typehints` which seem to be problematic when forward reference type checking is used even when applying the [recommendations](https://pypi.org/project/sphinx-autodoc-typehints/) for circular imports. It seems for https://github.com/apache/incubator-superset/pull/9824 which required `et_type_checking_flag = True` there were problems with Flask-Login and the LocalProxy. Furthermore there seems to be a number of open [issues](https://github.com/agronholm/sphinx-autodoc-typehints/issues) with the package, and thus I wondered if there was merit in disabling this until we have Python 3.7 as the minimum version when we can leverage [postponed evaluations and annotations](https://docs.python.org/3/whatsnew/3.7.html#pep-563-postponed-evaluation-of-annotations). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
