john-bodley opened a new pull request #9862: URL: https://github.com/apache/incubator-superset/pull/9862
This reverts commit 949c4eae280a5e39202855a7928f0b578d6436b3. ### SUMMARY This PR reverts https://github.com/apache/incubator-superset/pull/9692 as we should probably preserve comments to ensure that any database error references the correct line number. There's been confusion with a number of users where an error references the wrong line when compared to SQL Lab as lines containing comments have been stripped. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
