etr2460 commented on a change in pull request #9826:
URL:
https://github.com/apache/incubator-superset/pull/9826#discussion_r428881945
##########
File path: superset-frontend/src/reduxUtils.ts
##########
@@ -52,17 +67,22 @@ export function alterInArr(state, arrKey, obj, alterations,
idKey = 'id') {
return { ...state, [arrKey]: newArr };
}
-export function removeFromArr(state, arrKey, obj, idKey = 'id') {
- const newArr = [];
- state[arrKey].forEach(arrItem => {
+export function removeFromArr(
+ state: Record<string, any>,
+ arrKey: string,
+ obj: Record<string, any>,
+ idKey = 'id',
Review comment:
actually, because the type is auto inferred from the default value, the
linter auto removes it. so this should stay as is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
