mistercrunch opened a new pull request #9882:
URL: https://github.com/apache/incubator-superset/pull/9882


   ### SUMMARY
   closes https://github.com/apache/incubator-superset/issues/8871
   
   When constraints names aren't defined in sqlalchemy/alembic, they are 
non-deterministic, and it makes it hard/impossible to delete them in subsequent 
migrations. Here a bad constraint was created originally without a name, and 
some other migration tries to re-create it, and may fail on a subset of 
database engines. Also I think sqlite doesn't support constraint making the 
whole thing more of a headache.
   
   I decided to go back to the first migration and prevent the constraint to be 
created in the first place. Try to delete the constraint in the subsequent 
migrations, and finally create the appropriate one.
   
   TODO: We should squash [at least a subset of] migrations eventually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to