[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models

Thu, 21 May 2020 23:33:31 -0700 


codecov-commenter edited a comment on pull request #9883:
URL: 
https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253


   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1)
 Report
   > Merging 
[#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc)
 will **decrease** coverage by `0.18%`.
   > The diff coverage is `92.74%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9883/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9883      +/-   ##
   ==========================================
   - Coverage   71.24%   71.05%   -0.19%     
   ==========================================
     Files         584      584              
     Lines       30790    30809      +19     
     Branches     3238     3238              
   ==========================================
   - Hits        21936    21892      -44     
   - Misses       8744     8800      +56     
   - Partials      110      117       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.06% <ø> (-0.77%)` | :arrow_down: |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.40% <92.74%> (+0.01%)` | :arrow_up: |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=)
 | `61.20% <80.95%> (-1.18%)` | :arrow_down: |
   | 
[superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=)
 | `88.78% <89.13%> (+0.11%)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `88.60% <100.00%> (ø)` | |
   | 
[superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5)
 | `100.00% <100.00%> (ø)` | |
   | 
[superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5)
 | `92.59% <100.00%> (+0.28%)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.29% <100.00%> (ø)` | |
   | 
[superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==)
 | `88.59% <100.00%> (+0.10%)` | :arrow_up: |
   | 
[superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==)
 | `89.58% <100.00%> (ø)` | |
   | 
[superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5)
 | `83.95% <100.00%> (+0.17%)` | :arrow_up: |
   | 
[superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=)
 | `92.50% <100.00%> (+0.12%)` | :arrow_up: |
   | ... and [20 
more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer).
 Last update 
[3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to