mistercrunch commented on a change in pull request #9891:
URL:
https://github.com/apache/incubator-superset/pull/9891#discussion_r429652117
##########
File path: superset-frontend/src/dashboard/components/Dashboard.jsx
##########
@@ -159,11 +159,27 @@ class Dashboard extends React.PureComponent {
// added filter?
[].push.apply(affectedChartIds, activeFilters[filterKey].scope);
} else {
- // changed filter field value or scope?
- const affectedScope = (activeFilters[filterKey].scope || []).concat(
- appliedFilters[filterKey].scope || [],
- );
- [].push.apply(affectedChartIds, affectedScope);
+ // has filter field value change?
+ if (
+ !areObjectsEqual(
+ appliedFilters[filterKey].values,
+ activeFilters[filterKey].values,
+ )
+ ) {
+ [].push.apply(affectedChartIds, activeFilters[filterKey].scope);
Review comment:
NIT(optional ): I had to lookup what `[].push.apply`might do. For me
`affectedChartIds.push(...activeFilters[filterKey].scope)` would be more
readable (I think it's equivalent?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
