etr2460 commented on a change in pull request #9933:
URL:
https://github.com/apache/incubator-superset/pull/9933#discussion_r431454775
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/filter.js
##########
@@ -56,8 +56,26 @@ export default () =>
cy.get('.Select__control')
.contains('Select [region]')
.click({ force: true });
+
+ // should open the filter indicator
+ cy.get('.filter-indicator.active')
+ .should('be.visible')
+ .should($node => {
Review comment:
why prefix node with a dollar sign? Can we get rid of that in the
variable name?
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/filter.js
##########
@@ -56,8 +56,26 @@ export default () =>
cy.get('.Select__control')
.contains('Select [region]')
.click({ force: true });
+
+ // should open the filter indicator
+ cy.get('.filter-indicator.active')
+ .should('be.visible')
+ .should($node => {
+ expect($node).to.have.length(9);
+ });
+
+ cy.get('.chart-header').first().click({ force: true });
+
+ // should hide the filter indicator
+ cy.get('.filter-indicator')
+ .not('.active')
+ .should($node => {
Review comment:
same comment about the dollar sign here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
