villebro commented on a change in pull request #9905:
URL:
https://github.com/apache/incubator-superset/pull/9905#discussion_r431588088
##########
File path: superset/utils/cache.py
##########
@@ -14,14 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from typing import Callable, Optional
+from typing import Any, Callable, Optional
from flask import request
from superset.extensions import cache_manager
-def view_cache_key(*_, **__) -> str:
+def view_cache_key(*args: Any, **kwargs: Any) -> str: # pylint:
disable=unused-argument
Review comment:
Fair point about `_` being ambiguous in this context, i.e. either
signalling something that's unused or a `flask_babel` function call. I'm fine
with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
