john-bodley commented on a change in pull request #9943:
URL:
https://github.com/apache/incubator-superset/pull/9943#discussion_r434182759
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
@villebro I'm not sure if you're aware but numerous files have `pylint`
checks and warnings (not errors) disabled including `viz.py` per the line:
```
# pylint: disable=C,R,W
```
Note the plan is to address this in
[SIP-46](https://github.com/apache/incubator-superset/issues/9953). Note I'm
not quite mentally prepared for that saga yet as the typing work has left me a
tad battered and bruised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
