serenajiang opened a new pull request #9971:
URL: https://github.com/apache/incubator-superset/pull/9971


   ### SUMMARY
   Previously, hive csv upload only supported `,` as a delimiter. This is 
confusing for users because the UI allows you to specify a delimiter.
   
   This PR uses `org.apache.hadoop.hive.contrib.serde2.MultiDelimitSerDe` in 
hive csv upload, which supports regex delimiters. Mostly did this to support 
delimiters like `\s+` and `\t`, but potentially, any regex could be used. 
   
   More on `MultiDelimitSerDe`: 
https://cwiki.apache.org/confluence/display/Hive/MultiDelimitSerDe
   
   ### TEST PLAN
   Tested csv + tsv uploads.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   @etr2460 @bkyryliuk @john-bodley 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to