villebro opened a new pull request #10048:
URL: https://github.com/apache/incubator-superset/pull/10048


   ### SUMMARY
   Currently registering a `buildQuery` function with the 
`ChartBuildQueryRegistry` is mandatory for all V1 viz plugins. While a custom 
`buildQuery` is needed for advanced post processing operations, in the majority 
of cases this is not needed, as control values can be automatically grouped 
using the `queryField` control property. Using a default callback will make it 
easier to get started with viz plugin development, and reduce plugin 
boilerplate.
   
   ### TEST PLAN
   CI + new test with current pinned `superset-ui` dependencies. Also tested to 
work properly with the new word cloud plugin with and without a `buildQuery` 
callback.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to