mistercrunch opened a new pull request #10056: URL: https://github.com/apache/incubator-superset/pull/10056
Spent 1-2 hours playing around to get a sense of how much we can push towards `SIP-34`'s look & feel with limited effort. TODO: - colors went in smoothly, though we need a new Superset logo with the new `@brand-primary` color! - text on `btn-sm` isn't aligned, the new font we use isn't aligned with the pixels it reserves - SIP-34 primary and secondary buttons don't look good in button groups where it's unclear where one button and the next starts. I think we'll be moving away from using `btn-group` and have buttons side by side (with a gap) and the extra buttons into dropdowns - but this requires touching layouts (not just CSS). Bootstrap offers `btn-primary` and `btn-default`, but no tierciary. For now I rolled with using what SIP-34 defines as tierciary on `btn-default` to work around the group issue - SQL Lab tab headers are buttons but shouldn't be, as a result they got uppercased. We need to get them out of buttons ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
