villebro opened a new pull request #10062:
URL: https://github.com/apache/incubator-superset/pull/10062


   ### SUMMARY
   If a viz plugin doesn't provide a `buildQuery` function, exporting charts 
(JSON, CSV) fails.
   
   (FYI: this code will soon be replaced with `ChartClient` from 
`@superset-ui/chart`, hence not adding tests for this).
   
   ### TEST PLAN
   CI + local testing by verifying that old+new charts render properly on 
dashboards and Explore mode, and that all export options still work (CSV, JSON, 
Samples, Query).
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to