Nj-kol opened a new pull request #10084:
URL: https://github.com/apache/incubator-superset/pull/10084


   ### SUMMARY
   
   The issue was first observed in 
https://github.com/apache/incubator-superset/issues/7270
   However, in the subsequent releases, the variable **time_grain_functions** 
was renamed to **_time_grain_expressions**. The implementation was also left 
out for hive. So time functions were not renamed which were specific to Hive. 
This was causing the group by functions in the Charts to malfunction
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to