willbarrett opened a new pull request #10092: URL: https://github.com/apache/incubator-superset/pull/10092
### SUMMARY When working on a visualization in Explore, if there were changes to the visualization that had not been "run" via the "Run Query" button, they would be lost when editing the related datasource via the modal on the page. Why? The reducer that updated the `form_data` when a form component changed was broken in such a way that it would update the control settings to make the change visible, but not the `form_data` settings to make the change durable. This PR retains the behavior of not updating the encoded data in the URL until the "Run Query" button is pressed. **Question for the community**: are there any tests for any of the reducers in Superset? Can someone point me to an example? I'd love to write some tests for this change to avoid a regression. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
