etr2460 commented on a change in pull request #10073:
URL:
https://github.com/apache/incubator-superset/pull/10073#discussion_r442562056
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -243,28 +272,38 @@ export default class FilterableTable extends
PureComponent {
return values.some(v => v.includes(lowerCaseText));
}
- rowClassName({ index }) {
+ rowClassName({ index }: { index: number }) {
let className = '';
if (this.props.striped) {
className = index % 2 === 0 ? 'even-row' : 'odd-row';
}
return className;
}
- sort({ sortBy, sortDirection }) {
+ sort({
+ sortBy,
+ sortDirection,
+ }: {
+ sortBy: string;
+ sortDirection: SortDirectionType;
+ }) {
this.setState({ sortBy, sortDirection });
}
fitTableToWidthIfNeeded() {
- const containerWidth = this.container.clientWidth;
+ const containerWidth = this.container.current!.clientWidth;
Review comment:
unclear to be honest. I think I should trust TypeScript's typing here
though, and not having current threw an error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
