[GitHub] [incubator-superset] ktmud opened a new pull request #10143: fix: FilterBox JS when no results

Tue, 23 Jun 2020 19:04:02 -0700 


ktmud opened a new pull request #10143:
URL: https://github.com/apache/incubator-superset/pull/10143


   ### SUMMARY
   
   This fixes two small bugs for FilterBox
   
   1. When query results has zero records, instead of throwing a JS error, we 
allow the select control to render:
   
      Before:
   
      
![Snip20200623_2](https://user-images.githubusercontent.com/335541/85488581-68187d00-b583-11ea-841a-d9ef4481aa13.png)
   
      After:
   
      
![Snip20200623_3](https://user-images.githubusercontent.com/335541/85488617-7797c600-b583-11ea-8df6-de68767c2c41.png)
   
   2. Make it possible to create multiple freeform options: 
   
      <img 
src="https://user-images.githubusercontent.com/335541/85488839-d78e6c80-b583-11ea-9312-c1c9092417b2.png";
 width="300" />
   
     Previously new options will just replace old freeform option.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See above
   
   ### TEST PLAN
   
   Manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to