willbarrett commented on a change in pull request #5099:
URL:
https://github.com/apache/incubator-superset/pull/5099#discussion_r445160570
##########
File path:
superset/migrations/versions/76a4d742cf04_dashboard_role_many_to_many.py
##########
@@ -0,0 +1,29 @@
+"""dashboard role many to many
+
+Revision ID: b21a4c518cab
+Revises: e866bd2d4976
+Create Date: 2018-03-08 16:30:36.924096
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '76a4d742cf04'
+down_revision = '5ccf602336a0'
+
+from alembic import op
+import sqlalchemy as sa
+
+
+def upgrade():
+ op.create_table('dashboard_role',
Review comment:
I'm a fan of proper foreign keys in join tables over FKs in permisssion
names - it makes the data model more explicit and we can more easily enforce
data consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
