ktmud opened a new pull request #10158:
URL: https://github.com/apache/incubator-superset/pull/10158
### SUMMARY
This PR made multiple changes to Cypress tests:
- #### Upgrade Cypress to 4.7.0
Some E2E tests has been flaky, especially with the "should apply filter"
test in dashboard (never ran into an issue while debugging locally, but fails
from time to time in CI). I'm reluctant to disable/skip it as it does feel
important. Let's see if upgrading Cypress fixes it.
- #### Re-enable visualization tests
End-to-end tests for editing visualizations have been disabled for some
time ([most likely
unintentionally](https://github.com/apache/incubator-superset/pull/9490#discussion_r406502040)).
Let's reenable it to ensure the safety of charting experience.
Fixed a couple of broken tests.
- #### Split tests into independent `.test.js` files
The [original intention of combining all
tests](https://github.com/apache/incubator-superset/pull/6019) in a
`index.test.js` file was to speed things up because of overhead of starting
Chrome for each file. But it has been verified that latest Cypress has no such
overhead.
This change will make debugging a specific test easier.
### TEST PLAN
CI should pass
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
