bkyryliuk commented on a change in pull request #9944:
URL:
https://github.com/apache/incubator-superset/pull/9944#discussion_r445763311
##########
File path: superset/utils/screenshots.py
##########
@@ -218,28 +229,39 @@ def get(
:param thumb_size: Override thumbnail site
"""
payload: Optional[bytes] = None
- thumb_size = thumb_size or self.thumb_size
+ cache_key = self.cache_key(self.window_size, thumb_size)
if cache:
- payload = cache.get(self.cache_key)
+ payload = cache.get(cache_key)
if not payload:
payload = self.compute_and_cache(
user=user, thumb_size=thumb_size, cache=cache
)
else:
- logger.info(f"Loaded thumbnail from cache: {self.cache_key}")
+ logger.info(f"Loaded thumbnail from cache: {cache_key}")
if payload:
return BytesIO(payload)
return None
- def get_from_cache(self, cache: "Cache") -> Optional[BytesIO]:
- payload = cache.get(self.cache_key)
+ def get_from_cache(
+ self, cache: "Cache", window_size=None, thumb_size=None,
+ ) -> Optional[BytesIO]:
+ cache_key = self.cache_key(window_size, thumb_size)
+ payload = cache.get(cache_key)
+ return self.get_from_cache_key(cache, cache_key)
+
+ @staticmethod
+ def get_from_cache_key(cache: "Cache", cache_key: str) ->
Optional[BytesIO]:
+ logger.info("Attempting to get from cache: %s", cache_key)
+ payload = cache.get(cache_key)
if payload:
return BytesIO(payload)
+ logger.info("Failed at getting from cache: %s", cache_key)
return None
def compute_and_cache( # pylint: disable=too-many-arguments
self,
user: "User" = None,
+ window_size: Optional[WindowSize] = None,
Review comment:
would be nice to have a timeout and time to live here
e.g. for hourly alerts ttl should be 1 hour tops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
