[GitHub] [incubator-superset] lilykuang opened a new pull request #10178: style: new toast design closer to SIP-34

[GitBox]

lilykuang opened a new pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - update Toast style to match SIP-34
   - change `Toast` and `ToastPresenter` to typescript 
   - move `toast.less` to emotion style
   - only for SUCCESS `Toast`
   
   **Planning**
   - add Icon and style for error toast 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   **Before**
   <img width="1792" alt="before_toast" 
src="https://user-images.githubusercontent.com/5705598/85901482-d1cc9d00-b7b6-11ea-9d19-beb98086c14e.png";>
   **After**
   <img width="1792" alt="after_toast" 
src="https://user-images.githubusercontent.com/5705598/85901594-050f2c00-b7b7-11ea-9f65-b4db810ec94d.png";>
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - toggle ENABLE_REACT_CRUD_VIEWS config flag, see changes in dataset/chart 
view
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org