bkyryliuk commented on pull request #10177: URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650450453
> 1. Code coverage is missing > <img alt="" width="300" src="https://user-images.githubusercontent.com/335541/85908543-5b399a80-b7ca-11ea-9e57-b90ec0206069.png";> > 2. Might want to remove `nosetests` from pip dependencies and clean [this](https://github.com/apache/incubator-superset/blob/master/setup.cfg#L36-L41) up as well. @ktmud good catch. Will do the 1. As for point 2 - I changed nosetests there to the tool:pytest ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/85908543-5b399a80-b7ca-11ea-9e57-b90ec0206069.png"](https://user-images.githubusercontent.com/335541/85908543-5b399a80-b7ca-11ea-9e57-b90ec0206069.png"){kind=link}