bkyryliuk commented on pull request #10177: URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-651278422
> Codecov seems to be stuck at "[waiting for CI to complete](https://codecov.io/gh/apache/incubator-superset/commit/6a695f9f62b25b601afdea50403c4717b2b56f6e)", just like in #10142 . If you can get it fixed, that'd be great. If not, we can probably just merge this as is and see if it's a recurring issue in the next PR. > > There were also some deprecation warnings in the logs that might worth fixing (could be in another PR): > > ``` > tests/security_tests.py::TestRolePermission::test_set_perm_slice > /home/runner/work/incubator-superset/incubator-superset/tests/security_tests.py:425: DeprecationWarning: Please use assertEqual instead. > self.assertEquals(slice.schema_perm, table.schema_perm) > ``` @ktmud this is interesting, report is generated on their side: https://codecov.io/gh/apache/incubator-superset/pull/10177 however was not send to update the PR, will amend the PR and see if it fixes it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
