[GitHub] [incubator-superset] etr2460 opened a new pull request #10243: feat: support new errors payload in SQL Lab

[GitBox]

etr2460 opened a new pull request #10243:
URL: https://github.com/apache/incubator-superset/pull/10243


   ### SUMMARY
   Some query requests (namely security manager failures) already return errors 
in the new format, so we need to make sure the frontend can handle the new 
payload.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Custom error renderer:
   <img width="1587" alt="Screen Shot 2020-07-04 at 9 34 42 PM" 
src="https://user-images.githubusercontent.com/7409244/86526050-e1e21d80-be43-11ea-8399-c31afca92678.png";>
   Successful query:
   <img width="1600" alt="Screen Shot 2020-07-04 at 9 40 16 PM" 
src="https://user-images.githubusercontent.com/7409244/86526051-e3134a80-be43-11ea-93b9-83917a57018c.png";>
   Old error format:
   <img width="1593" alt="Screen Shot 2020-07-04 at 9 40 36 PM" 
src="https://user-images.githubusercontent.com/7409244/86526052-e4447780-be43-11ea-9a52-c1f429473856.png";>
   
   ### TEST PLAN
   Unit tests, CI
   - Ensure that security manager errors render with a custom error renderer
   - Ensure successful queries render properly
   - Ensure error payloads of the old format still render properly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @rusackas @graceguo-supercat @ktmud 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org