villebro commented on a change in pull request #9964:
URL:
https://github.com/apache/incubator-superset/pull/9964#discussion_r450090804
##########
File path: superset/charts/schemas.py
##########
@@ -725,20 +727,20 @@ class ChartDataQueryContextSchema(Schema):
)
result_type = fields.String(
description="Type of results to return",
- validate=validate.OneOf(choices=("full", "query", "results",
"samples")),
+ validate=validate.OneOf(choices=("query", "results", "samples")),
Review comment:
`full` should be a valid choice here, see for instance
https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/chart/chartAction.js#L343-L350
##########
File path: tests/datasets/api_tests.py
##########
@@ -404,6 +411,12 @@ def test_update_dataset_update_column(self):
# Get current cols and alter one
rv = self.get_assert_metric(uri, "get")
resp_columns = json.loads(rv.data.decode("utf-8"))["result"]["columns"]
+ for column in resp_columns:
+ column.pop("changed_on", None)
+ column.pop("created_on", None)
+ column.pop("changed_on", None)
+ column.pop("changed_on", None)
Review comment:
Same here
##########
File path: tests/datasets/api_tests.py
##########
@@ -371,6 +371,13 @@ def test_update_dataset_create_column(self):
self.login(username="admin")
rv = self.get_assert_metric(uri, "get")
data = json.loads(rv.data.decode("utf-8"))
+
+ for column in data["result"]["columns"]:
+ column.pop("changed_on", None)
+ column.pop("created_on", None)
+ column.pop("changed_on", None)
+ column.pop("changed_on", None)
Review comment:
aren't these redundant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
