[GitHub] [incubator-superset] ktmud opened a new pull request #10250: fix(table-viz): JS error when sort time column

[GitBox]

ktmud opened a new pull request #10250:
URL: https://github.com/apache/incubator-superset/pull/10250


   ### SUMMARY
   
   
   1. Fix `getTime` undefined error when sorting a time column in table chart. 
Also refactors how datetime is handled for `react-table` search, sort and 
render methods.
   
      <img 
src="https://user-images.githubusercontent.com/335541/86659460-b9226b00-bf9e-11ea-82c6-91888ae94561.png";
 width="500">
   
   2. Fix spacing issue for table pagination in dashboards
      
      **Before:**
   
      <img 
src="https://user-images.githubusercontent.com/335541/86662583-b2492780-bfa1-11ea-9b65-a0cf1ea91a91.png";
 width="600">
   
      **After:**
   
      <img 
src="https://user-images.githubusercontent.com/335541/86662505-9fceee00-bfa1-11ea-8e0e-0806e215c8e1.png";
 width="600">
   
   
   Related: https://github.com/apache-superset/superset-ui/pull/669
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See SUMMARY.
   
   ### TEST PLAN
   
   Unit test in superset-ui and E2E test in superset-frontend.
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org