[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #10257: feat: minor reorder SQL Lab Tab controls

Wed, 08 Jul 2020 10:31:14 -0700 


graceguo-supercat opened a new pull request #10257:
URL: https://github.com/apache/incubator-superset/pull/10257


   ### SUMMARY
   A few airbnb users reported that they accidentally clicked status icon in 
SQL Lab's tab, and they lost the active query.
   This PR is to re-order the controls in each SQL Lab tab to prevent such 
accidents.
   
   - re-order dropdown menu and tab title
   - separate the status icon and close button
   - always show close button at the right-side
   
   Thanks for @kenchendesign brought up design!
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   <img width="429" alt="Screen Shot 2020-07-07 at 4 11 32 PM" 
src="https://user-images.githubusercontent.com/27990562/86950183-b0e44000-c104-11ea-8118-c0493a57c8be.png";>
   
   
   **After:**
   <img width="825" alt="Screen Shot 2020-07-08 at 9 36 37 AM" 
src="https://user-images.githubusercontent.com/27990562/86950166-a75ad800-c104-11ea-8f6a-0ef9dd983409.png";>
   
   
   ### TEST PLAN
   Manual test.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to