[GitHub] [incubator-superset] ktmud opened a new pull request #10264: fix: optimize mapStateToProps for chart controls

[GitBox]

ktmud opened a new pull request #10264:
URL: https://github.com/apache/incubator-superset/pull/10264


   ### SUMMARY
   
   This is a bug fix for "EXPLORE" button in SQL query results.
   
   The query mode control for table chart relies on `controls` prop in control 
panel state to determine what's the actual query mode, so it must `controls` 
state mapping for chart controls must be initialized before `mapStateToProps` 
is called.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   When clicking on the "EXPLORE" button in SQL Lab:
   
   <img 
src="https://user-images.githubusercontent.com/335541/86982480-30423580-c13e-11ea-9cb3-3b4687dfe607.png";
 width="400" />
   
   #### Before: 
   
   Query is successful, but query mode is incorrectly set to "Aggregate":
   
   <img 
src="https://user-images.githubusercontent.com/335541/86982518-4cde6d80-c13e-11ea-8a39-cddc20db1380.png";
 width="600">
   
   #### After:
   
   Query successfully switches to "Raw" mode:
   
   <img 
src="https://user-images.githubusercontent.com/335541/86984619-f116e300-c143-11ea-8f3d-9557032bfeb8.png";
 width="600">
   
   ### TEST PLAN
   
   Updated unit test + manual testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #10113 
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   
   cc @kristw @serenajiang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org