lilykuang commented on a change in pull request #10178:
URL:
https://github.com/apache/incubator-superset/pull/10178#discussion_r451926905
##########
File path: superset-frontend/src/messageToasts/components/Toast.tsx
##########
@@ -97,13 +117,17 @@ class Toast extends React.Component {
toastType === DANGER_TOAST && 'toast--danger',
)}
>
- <Interweave content={text} />
+ <ToastContianer>
+ {toastType === SUCCESS_TOAST ? (
+ <Icon name="check" />
+ ) : (
+ <Icon name="error" />
+ )}
Review comment:
I will prefer info toasts without Icon and warning toasts will have the
same icon as error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
