[GitHub] [incubator-superset] etr2460 opened a new pull request #10274: feat: update timeout error UX

[GitBox]

etr2460 opened a new pull request #10274:
URL: https://github.com/apache/incubator-superset/pull/10274


   ### SUMMARY
   Implements new error designs within Superset, starting with timeout errors. 
This standardizes all timeout errors, frontend and backend, to the UI 
component. Future errors will be built following this same pattern. Also adds 
documentation pointers for potential root causes so users can unblock themselves
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="630" alt="Screen Shot 2020-07-09 at 8 56 29 AM" 
src="https://user-images.githubusercontent.com/7409244/87076656-e5283100-c1d6-11ea-8fd6-931a3b62e063.png";>
   <img width="633" alt="Screen Shot 2020-07-09 at 8 56 36 AM" 
src="https://user-images.githubusercontent.com/7409244/87076661-e6595e00-c1d6-11ea-8f11-5df074f4ba02.png";>
   <img width="1590" alt="Screen Shot 2020-07-09 at 8 56 46 AM" 
src="https://user-images.githubusercontent.com/7409244/87076667-e78a8b00-c1d6-11ea-9071-4081887696e0.png";>
   <img width="1576" alt="Screen Shot 2020-07-09 at 8 56 53 AM" 
src="https://user-images.githubusercontent.com/7409244/87076669-e8232180-c1d6-11ea-9879-2c3e1b032054.png";>
   <img width="1895" alt="Screen Shot 2020-07-09 at 8 57 00 AM" 
src="https://user-images.githubusercontent.com/7409244/87076671-e8232180-c1d6-11ea-83b5-a764b72cb717.png";>
   <img width="636" alt="Screen Shot 2020-07-09 at 8 57 06 AM" 
src="https://user-images.githubusercontent.com/7409244/87076673-e8bbb800-c1d6-11ea-9344-cad604854dce.png";>
   <img width="787" alt="Screen Shot 2020-07-09 at 11 13 38 AM" 
src="https://user-images.githubusercontent.com/7409244/87076675-e9544e80-c1d6-11ea-820f-b89a548f9b66.png";>
   
   ### TEST PLAN
   CI + unit tests
   Set the timeouts to 1 second and see the new error component across 
Dashboards, Explore, and SQL Lab. Ensure everything renders correctly when 
there are no errors.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @graceguo-supercat @ktmud @nytai @rusackas 
   cc: @Steejay


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org