john-bodley opened a new pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279


   ### SUMMARY
   
   Per the Celery 
[documentation](https://docs.celeryproject.org/en/stable/reference/celery.result.html#celery-result)
 in relation to Celery results, 
   
   > **Warning:**
   Backends use resources to store and transmit results. To ensure that 
resources are released, you must eventually call `get()` or `forget()` on EVERY 
AsyncResult instance returned after calling a task.
   
   which we aren't doing. Given we actually don't store the SQL Lab payloads in 
the Celery results backend holding onto these task result metadata for [24 
hours](https://docs.celeryproject.org/en/latest/userguide/configuration.html#result-expires)
 seems unnecessary and can result in having thousands of redundant records (at 
Airbnb we have in excess of 10,000 keys which could be retired). It seems 
fairly trivial to clean as we go.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to