villebro commented on a change in pull request #10286:
URL:
https://github.com/apache/incubator-superset/pull/10286#discussion_r452946333
##########
File path: superset/charts/schemas.py
##########
@@ -395,6 +395,19 @@ class
ChartDataSortOptionsSchema(ChartDataPostProcessingOperationOptionsSchema):
aggregates = ChartDataAggregateConfigField()
+class
ChartDataContributionOptionsSchema(ChartDataPostProcessingOperationOptionsSchema):
+ """
+ Contribution operation config.
+ """
+
+ orientation = fields.String(
+ description="Should cell values be calculated across the row or
column.",
+ required=True,
+ validate=validate.OneOf(choices=("row", "column",)),
Review comment:
Yeah, with the introduction of marshmallow3, I think we can do a bunch
of cleanup work on these. I'm going to look into cleaning these up next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
