ktmud commented on a change in pull request #10284:
URL:
https://github.com/apache/incubator-superset/pull/10284#discussion_r452996375
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
I like the piece of mind ternary gives me as it's more explicit and
wouldn't break things when `isEditable` is a truthy non-boolean value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
